Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-export link and dlink from traitlets for consistency with the javascript api #1923

Merged
merged 2 commits into from
Jan 25, 2018
Merged

re-export link and dlink from traitlets for consistency with the javascript api #1923

merged 2 commits into from
Jan 25, 2018

Conversation

rprimet
Copy link
Contributor

@rprimet rprimet commented Jan 23, 2018

…script API

@rprimet
Copy link
Contributor Author

rprimet commented Jan 23, 2018

(related issue: #1809)

@jasongrout
Copy link
Member

Thank you! Can we also delete the cell in the example where traitlets is imported?

@jasongrout jasongrout changed the title re-export link and dlink from traitlets for consistency with the java… re-export link and dlink from traitlets for consistency with the javascript api Jan 24, 2018
@jasongrout jasongrout added this to the Minor release milestone Jan 24, 2018
@rprimet
Copy link
Contributor Author

rprimet commented Jan 24, 2018

Good catch, thanks! This should be fixed now.

@jasongrout
Copy link
Member

Thank you!

@jasongrout jasongrout merged commit 648dd00 into jupyter-widgets:master Jan 25, 2018
@jasongrout jasongrout mentioned this pull request Jan 25, 2018
Closed
@rprimet rprimet deleted the link_export branch January 25, 2018 16:34
@SylvainCorlay
Copy link
Member

Quick note @rprimet, your git configuration does not match your GitHub user email so that your account is not credited with this commit. Sorry for not catching that earlier.

@rprimet
Copy link
Contributor Author

rprimet commented Jan 30, 2018

Ah thanks for that ! I'll update my git config.

@jasongrout jasongrout modified the milestones: Minor release, 7.2 Mar 19, 2018
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@rprimet @jasongrout @SylvainCorlay