Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1979: Add generation of JSON for widget specs which is then used to create MD. #2193

Merged
merged 5 commits into from
Jan 10, 2020

Conversation

reggied
Copy link

@reggied reggied commented Aug 31, 2018

No description provided.

@jasongrout
Copy link
Member

I extended the program a bit to have an option to generate a json file, and also checked in the current json file. This is so people can read in that json file and do the programmatic checking they want.

@SylvainCorlay - could you look at this, and in particular look at the JSON spec generated, and let us know if it looks good to you?

@SylvainCorlay
Copy link
Member

PS: @reggied, FYI you did not use the same email for your commits as the one that is registered for your GitHub account.

In order to be creditted by GitHub for these commits, either we can rebase an use the same email as in https://github.com/django-salesforce/django-salesforce/commit/0d4a4de143853b6326f78796d74e35800e57196b.patch or add this email to the GitHub account.

@SylvainCorlay SylvainCorlay added this to the 8.0 milestone Jan 10, 2020
@SylvainCorlay SylvainCorlay self-assigned this Jan 10, 2020
@SylvainCorlay
Copy link
Member

Rebased.

@SylvainCorlay
Copy link
Member

Thanks @reggied!

Sorry for taking so long. I am merging the PR.

@SylvainCorlay SylvainCorlay merged commit 00edc81 into jupyter-widgets:master Jan 10, 2020
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants