Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated overflow properties #2688

Conversation

SylvainCorlay
Copy link
Member

No description provided.

@pbugnion
Copy link
Member

pbugnion commented Jan 8, 2020

I think examples/Widget Styling.ipynb in the docs also contains references to overflow_{x,y}.

@SylvainCorlay SylvainCorlay force-pushed the deprecated-overflow-properties branch from 5cef6f7 to 4cc0e1c Compare January 8, 2020 12:46
@SylvainCorlay SylvainCorlay requested a review from pbugnion January 8, 2020 12:52
@SylvainCorlay SylvainCorlay added this to the 8.0 milestone Jan 8, 2020
@pbugnion pbugnion self-assigned this Jan 8, 2020
@SylvainCorlay SylvainCorlay force-pushed the deprecated-overflow-properties branch from 4cc0e1c to e6eceeb Compare January 8, 2020 14:04
" Inspector.\"\"\"\n",
" self._box._ipython_display_()\n"
" def _repr_mimebundle_(self, **kwargs):\n",
" return self._box._repr_mimebundle_(**kwargs)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to remove the _ipython_display_ call because if was removed from the base Jupyter widget.

@pbugnion
Copy link
Member

pbugnion commented Jan 8, 2020

Looks great!

@pbugnion pbugnion merged commit bd8be72 into jupyter-widgets:master Jan 8, 2020
@SylvainCorlay SylvainCorlay deleted the deprecated-overflow-properties branch May 11, 2020 22:50
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jun 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants