Change media widgets to use memory views. #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be more efficient with fewer copies in some cases, such as uploading a file and setting the value from the file content.
jasongrout
force-pushed
the
memoryview
branch
from
1f4e7f3 to
0680330
Compare
|
We should check the impact of this on ipywebrtc. |
|
As part of the work on this, we should change the docs for the file upload widget to avoid an unnecessary |
@maartenbreddels - are you able to do this? |
It may be easiest to do this with an alpha release of ipywidgets with this merged in. Can we merge this in, and revert later if there are problems? |
|
Merging - if it is an issue, especially with ipywebrtc or some other downstream library, we can revert. |
lock
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be more efficient with fewer copies in some cases, such as uploading a file and setting the value from the file content. Also, the deserialization does not involve a copy anymore.
CC @pbugnion, @maartenbreddels