Include example notebooks as data files in package #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainCorlay
force-pushed
the
include-notebooks-in-package
branch
from
fb61b21 to
239feaa
Compare
This comment has been minimized.
This comment has been minimized.
SylvainCorlay
force-pushed
the
include-notebooks-in-package
branch
6 times, most recently
from
211290f to
6ff0929
Compare
SylvainCorlay
changed the title
SylvainCorlay
commented
Mar 27, 2020
|
|
||
| html: | ||
| rm -rf ./source/notebooks/ && mkdir ./source/notebooks && cp -r ./../share/jupyter/notebook_templates/ipywidgets/* ./source/notebooks/ |
There was a problem hiding this comment.
I am not very happy that we need to refer to the current (makefile) directory as .. There is no variable storing the location of the makefile.
|
Note that this would likely also need a change to the |
Yes |
SylvainCorlay
force-pushed
the
include-notebooks-in-package
branch
from
6ff0929 to
af7d60a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPywidgets users who installed ipywidgets from PyPI or conda often have to consult the GitHub repository to find example notebooks.
In this PR we include the notebooks in the package as data files, so that they are installed alongside the package.
These "example notebooks" are picked up by lab extensions such as jupyterlab templates.
I would like to adopt this approach to include example notebooks with libraries.