Bugfix/parameters in the from file method to be passed along in the media class #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedarisetti
changed the title
|
Thanks! Can we separate this change from the change in #3075? |
kedarisetti
force-pushed
the
bugfix/media_from_file_params
branch
from
dd64ebe to
1962cfb
Compare
kedarisetti
force-pushed
the
bugfix/media_from_file_params
branch
from
1962cfb to
fb1c525
Compare
|
Done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra parameters in the from_url() method do not get passed on to the super class.
this fix passes the parameters along.