Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pWidget to lmWidget #3118

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Rename pWidget to lmWidget #3118

merged 2 commits into from
Feb 18, 2021

Conversation

davidbrochart
Copy link
Member

Fixes #3087

@willingc
Copy link
Contributor

@davidbrochart Consider renaming prefix from lm to lum. I keep reading it as I M instead of L M. For users and new contributors lm could be confusing.

@davidbrochart
Copy link
Member Author

Yes, it can be confusing. I don't have any problem with lumWidget, should we go ahead with this?

@jtpio
Copy link
Member

jtpio commented Feb 15, 2021

Maybe the original suggestion was lmWidget to follow a similar naming as for the CSS classes? (p-Widget and lm-Widget)

For example: https://github.com/jupyterlab/lumino/blob/4f2432290e874b040310d428593abe4afc336066/packages/widgets/style/widget.css#L11-L12

@willingc
Copy link
Contributor

@davidbrochart Given @jtpio's description of the source, let's leave as is in the PR. Thanks!

@willingc willingc self-requested a review February 16, 2021 02:53
@jasongrout
Copy link
Member

@davidbrochart Consider renaming prefix from lm to lum. I keep reading it as I M instead of L M. For users and new contributors lm could be confusing.

I also keep reading it as "I M" - note to self about never using l to start a name when it might be used in a camelcase situation!

There is precedence for using lmWidget, so I'm fine with moving forward with it, but if in the future we decide to do something different, I would rather go all the way and do luminoWidget over lumWidget.

jasongrout
jasongrout reviewed Feb 16, 2021
View reviewed changes
Copy link
Member

@jasongrout jasongrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with one comment about preserving pWidget typings in subclasses.

packages/controls/src/widget_selectioncontainer.ts Show resolved Hide resolved
packages/controls/src/widget_selectioncontainer.ts Show resolved Hide resolved
packages/html-manager/src/output.ts Show resolved Hide resolved
packages/controls/src/widget_box.ts Show resolved Hide resolved
packages/controls/src/widget_controller.ts Show resolved Hide resolved
@jasongrout jasongrout added this to the 8.0 milestone Feb 18, 2021
@jasongrout jasongrout mentioned this pull request Feb 18, 2021
Closed
@jasongrout
Copy link
Member

Thanks!

@jasongrout jasongrout merged commit f7abdc9 into jupyter-widgets:master Feb 18, 2021
@davidbrochart davidbrochart deleted the rename_pwidget branch February 18, 2021 18:16
@jasongrout jasongrout mentioned this pull request Feb 18, 2021
Closed
@jasongrout
Copy link
Member

We had generally positive sentiment in the widget dev meeting today to rename .lmWidget to .luminoWidget. I've made that #3137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio left review comments

@jasongrout jasongrout jasongrout left review comments

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

Rename .pWidget to .lmWidget
4 participants
@davidbrochart @willingc @jtpio @jasongrout