Update to Jupyter Packaging 0.10 #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
force-pushed
the
jupyter-packaging-0-9
branch
from
fcd824d to
860c97e
Compare
jtpio
changed the title
|
Need to check whether the test failure is related to jupyterlab/extension-cookiecutter-ts#146 |
|
We'll need to do that on all other widgets |
jtpio
changed the title
jtpio
force-pushed
the
jupyter-packaging-0-9
branch
from
4288b8f to
5ae06ce
Compare
|
Updating to |
bsyouness
approved these changes
May 17, 2021
|
Closing and reopening again to trigger the tests |
jasongrout
reviewed
May 19, 2021
| setup(cmdclass=cmdclass) | ||
| setup( | ||
| cmdclass=cmdclass, | ||
| data_files=get_data_files(data_files_spec), |
There was a problem hiding this comment.
@jtpio - I've been wondering about how jupyter_packaging handles data files that don't exist until after the build process. Part of the reason for the complicated build process before was that the data files could not be calculated until after the js was built. How are the data files retrieved with get_data_files before they are built now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the update in the TypeScript cookiecutter: https://github.com/jupyterlab/extension-cookiecutter-ts/pull/143/files
We might also want to update
widgetnbextension:ipywidgets/widgetsnbextension/pyproject.toml
Line 4 in e0d41f6
And: https://github.com/jupyter-widgets/ipywidgets/blob/master/widgetsnbextension/setup.py
Originally brought in #3185 (review)