Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade @types/backbone #3217

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Upgrade @types/backbone #3217

merged 2 commits into from
Jun 18, 2021

Conversation

jasongrout
Copy link
Member

@jasongrout jasongrout commented Jun 12, 2021 •
edited
Loading

Following up on #3215 (merge that first), this upgrades @types/backbone to the most recent version.

@jasongrout jasongrout force-pushed the upgrade-backbonetypes branch from 8361113 to a12e368 Compare June 12, 2021 01:38
@jtpio jtpio mentioned this pull request Jun 14, 2021
Closed
@vidartf vidartf added this to the 8.0 milestone Jun 15, 2021
@jtpio jtpio force-pushed the upgrade-backbonetypes branch from a12e368 to 871f2da Compare June 16, 2021 15:05
@jtpio jtpio linked an issue Jun 16, 2021 that may be closed by this pull request
Update to @types/backbone 1.4.5 #3002
Closed
@jtpio
Copy link
Member

jtpio commented Jun 17, 2021

Updated the types in the tests and the CI check now passes.

jtpio
jtpio approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 4132414 into jupyter-widgets:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

Update to @types/backbone 1.4.5
3 participants
@jasongrout @jtpio @vidartf