Update to the new Galata #3279
Update to the new Galata #3279
Conversation
|
|
|
This is only modifying the Moving to 8.1 so it's not a blocker, but might get back to it before. |
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "import ipywidgets as widgets\n", |
There was a problem hiding this comment.
Moving the import to the cell below, since Galata would otherwise block on trying to fetch the cell output with galata.notebook.getCellOutput() when there is no output.
|
Adding back to the 8.0 milestone for consideration since it should now be ready to go. |
| with: | ||
| node-version: 12.x | ||
| node-version: 14.x |
There was a problem hiding this comment.
Is Node 12 no longer supported?
There was a problem hiding this comment.
It could be that node 12 was causing issues for this workflow. Although other workflows still use that version.
We could try to switch back to 12 and see if the check fails.
There was a problem hiding this comment.
The CI check failed after switching to node 12 in this commit: https://github.com/jupyter-widgets/ipywidgets/runs/4313698147?check_suite_focus=true
With:
And passes after switching back to node 14: https://github.com/jupyter-widgets/ipywidgets/runs/4313796358?check_suite_focus=true
Fixes #3274
Update to the latest
@jupyterlab/galatanow living in the JupyterLab repo: https://github.com/jupyterlab/jupyterlab/blob/master/galataThis makes full use of
playwrightand helps simplify the UI Tests setup.TODO
@jupyterlab/galata@~4.0.2The test report can be downloaded from the summary page:
When the CI check fails, new reference snapshots are generated and uploaded: