Backport loadFromKernel nodifications to 8.x #3388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jasongrout
reviewed
Feb 18, 2022
| @@ -507,7 +542,7 @@ export abstract class ManagerBase implements IWidgetManager { | |||
|
|
|||
| let msg_id = ''; | |||
| const info = new PromiseDelegate<Private.ICommUpdateData>(); | |||
| comm.on_msg((msg: services.KernelMessage.ICommMsgMsg) => { | |||
There was a problem hiding this comment.
We lost a type annotation here that we should preserve.
jasongrout
reviewed
Feb 18, 2022
| @@ -370,11 +370,11 @@ This is implemented in ipywidgets 7.7. | |||
|
|
|||
| ### The `jupyter.widget.control` comm target | |||
|
|
|||
| A kernel-side Jupyter widgets library registers a `jupyter.widget.control` comm target that is used for fetching all widgets states through a "one shot" comm message (one for all widget instances). Unlike the `jupyter.widget` comm target, the created comm is global to all widgets, | |||
There was a problem hiding this comment.
I think we should ignore the changes to this file in this PR.
jasongrout
reviewed
Feb 18, 2022
| @@ -375,7 +375,7 @@ export abstract class ManagerBase implements IWidgetManager { | |||
| try { | |||
| const initComm = await this._create_comm( | |||
| CONTROL_COMM_TARGET, | |||
| uuid(), | |||
| utils.uuid(), | |||
There was a problem hiding this comment.
Suggested change
| utils.uuid(), | |
| uuid(), |
|
I took at crack at automated porting this one commit too. Not sure if it is any more successful, but may be useful for comparison: First, I slightly modified master to get it looking more like the 7.x before the commit in question: Then I applied the patch from jasongrout@0296e03 while ignoring whitespace (something like |
|
@jasongrout many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.