Deserialize state before setting it, as is done elsewhere set_state is used

[jasongrout]

This is causing at least one problem in the ipyleaflet 8.0 upgrade tests, as seen in jupyter-widgets/ipyleaflet#968

This code is similar to code from another place in this file that has similar logic:

ipywidgets/packages/base-manager/src/manager-base.ts

Lines 703 to 715 in bf68169

	// If the model has already been created, set its state and then
	// return it.
	if (this.has_model(model_id)) {
	return this.get_model(model_id)!.then((model) => {
	// deserialize state
	return (model.constructor as typeof WidgetModel)
	._deserialize_state(modelState || {}, this)
	.then((attributes) => {
	model.set_state(attributes); // case 2
	return model;
	});
	});
	}

[github-actions]

👈 Launch a binder notebook on branch jasongrout/ipywidgets/deserialize

[martinRenou]

Thanks a lot for investigating this! This looks good to me