Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: allow the layout of the dom widget to be None #3592

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

perf: allow the layout of the dom widget to be None #3592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dbe32c
perf: allow the layout of the dom widget to be None
maartenbreddels Sep 15, 2022
f5f11ea
bump version numbers for base, output and controls
maartenbreddels Sep 20, 2022
2e69a90
update spec
maartenbreddels Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/base/src/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Copyright (c) Jupyter Development Team.
// Distributed under the terms of the Modified BSD License.

export const JUPYTER_WIDGETS_VERSION = '2.0.0';
export const JUPYTER_WIDGETS_VERSION = '2.1.0';

export const PROTOCOL_VERSION = '2.1.0';
4 changes: 2 additions & 2 deletions packages/base/test/src/widget_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,10 +610,10 @@ describe('WidgetModel', function () {
expect(this.widget.get_state()).to.deep.equal({
_model_module: '@jupyter-widgets/base',
_model_name: 'WidgetModel',
_model_module_version: '2.0.0',
_model_module_version: '2.1.0',
_view_module: '@jupyter-widgets/base',
_view_name: null,
_view_module_version: '2.0.0',
_view_module_version: '2.1.0',
_view_count: null,
a: 'get_state test',
});
Expand Down
2 changes: 1 addition & 1 deletion packages/controls/src/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
* The version of the Jupyter controls widget attribute spec that this package
* implements.
*/
export const JUPYTER_CONTROLS_VERSION = '2.0.0';
export const JUPYTER_CONTROLS_VERSION = '2.1.0';
2 changes: 1 addition & 1 deletion packages/output/src/output.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { DOMWidgetModel, DOMWidgetView } from '@jupyter-widgets/base';

export const OUTPUT_WIDGET_VERSION = '1.0.0';
export const OUTPUT_WIDGET_VERSION = '1.1.0';

export class OutputModel extends DOMWidgetModel {
defaults(): Backbone.ObjectHash {
Expand Down
524 changes: 262 additions & 262 deletions packages/schema/jupyterwidgetmodels.latest.md
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions python/ipywidgets/ipywidgets/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
__control_protocol_version__ = '1.0.0'

# These are *protocol* versions for each package, *not* npm versions. To check, look at each package's src/version.ts file for the protocol version the package implements.
__jupyter_widgets_base_version__ = '2.0.0'
__jupyter_widgets_output_version__ = '1.0.0'
__jupyter_widgets_controls_version__ = '2.0.0'
__jupyter_widgets_base_version__ = '2.1.0'
__jupyter_widgets_output_version__ = '1.1.0'
__jupyter_widgets_controls_version__ = '2.1.0'

# A compatible @jupyter-widgets/html-manager npm package semver range
__html_manager_version__ = '^1.0.1'
2 changes: 1 addition & 1 deletion python/ipywidgets/ipywidgets/widgets/domwidget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class DOMWidget(Widget):
_dom_classes = TypedTuple(trait=Unicode(), help="CSS classes applied to widget DOM element").tag(sync=True)
tabbable = Bool(help="Is widget tabbable?", allow_none=True, default_value=None).tag(sync=True)
tooltip = Unicode(None, allow_none=True, help="A tooltip caption.").tag(sync=True)
layout = InstanceDict(Layout).tag(sync=True, **widget_serialization)
layout = InstanceDict(Layout, allow_none=True).tag(sync=True, **widget_serialization)

def add_class(self, className):
"""
Expand Down