-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'Develop and Build Documentation' with new instructions #3616
base: main
Are you sure you want to change the base?
Conversation
@supriyakhandekar volunteered to review this |
``` | ||
|
||
4. Open the documentation from the build directory: `docs/build/html` | ||
To build the ipywidgets documentation see the instructions available on - [Jupyter Widgets - Develop and Build Documentation](https://ipywidgets.readthedocs.io/en/latest/dev_install.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this what we want to provide a link to? Seems like the instructions in the dev_docs.md are mirroring the original readme here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instructions in the readme were removed so that we would not have to maintain two different sets of the same instructions on both the readme and the ipywidgets.readthedocs.io, but i can add back the readme instructions as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to maintain one set of instructions however it seems that the instructions here https://ipywidgets.readthedocs.io/en/latest/dev_install.html is for the dev install of ipywidgets, not specifically for documentation. And if we were to link https://ipywidgets.readthedocs.io/en/latest/dev_docs.html instead, this seems to be different set of instructions from the README instructions that you updated
PR Summary: