Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'Develop and Build Documentation' with new instructions #3616

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kellietay
Copy link

@kellietay kellietay commented Oct 21, 2022

PR Summary:

  • docs/readme.md was updated in this commit, but this change was not updated in the official readthedocs.
  • this PR migrates the instructions on docs/Readme.md to docs/dev_docs.md
  • We also update docs/Readme.md to point to the official docs.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch kellietay/ipywidgets/kt/update_documentation

@jasongrout
Copy link
Member

@supriyakhandekar volunteered to review this

@supriyakhandekar supriyakhandekar self-requested a review November 7, 2022 00:49
```

4. Open the documentation from the build directory: `docs/build/html`
To build the ipywidgets documentation see the instructions available on - [Jupyter Widgets - Develop and Build Documentation](https://ipywidgets.readthedocs.io/en/latest/dev_install.html)
Copy link

@supriyakhandekar supriyakhandekar Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what we want to provide a link to? Seems like the instructions in the dev_docs.md are mirroring the original readme here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions in the readme were removed so that we would not have to maintain two different sets of the same instructions on both the readme and the ipywidgets.readthedocs.io, but i can add back the readme instructions as well

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to maintain one set of instructions however it seems that the instructions here https://ipywidgets.readthedocs.io/en/latest/dev_install.html is for the dev install of ipywidgets, not specifically for documentation. And if we were to link https://ipywidgets.readthedocs.io/en/latest/dev_docs.html instead, this seems to be different set of instructions from the README instructions that you updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants