Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter_server_config.py: Listen on all interfaces (IPv4 and IPv6) #2204

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

manics
Copy link
Contributor

@manics manics commented Jan 27, 2025

Describe your changes

c.ServerApp.ip = "0.0.0.0" in jupyter_server_config.py configures jupyter-server to listen on all IPv4 interfaces.

Setting it to "" configures jupyter-server to listen on all available (IPv4 and IPv6) interfaces, ensuring these images work with IPv4, IPv6, and dual stack networks.

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@consideRatio consideRatio merged commit a85eb43 into jupyter:main Jan 27, 2025
33 checks passed
@mathbunnyru
Copy link
Member

@consideRatio please, do not use merge commits in this repo (when merging to main).
We've been squashes for more than 2 years and it's important for nice wiki updates (and more beautiful history in general).

@mathbunnyru
Copy link
Member

I noticed that new Julia version has been released, and it still hangs our self-hosted runners.
I updated our scripts not to use the new version (pushed it to main and then merged the change to all PRs).

@consideRatio
Copy link
Collaborator

I'm sorry @mathbunnyru!

We could update the settings to prohibit merge to enforce this, squash only?

@mathbunnyru
Copy link
Member

I'm sorry @mathbunnyru!

We could update the settings to prohibit merge to enforce this, squash only?

Thanks for the suggestion, done!

Screenshot 2025-01-27 at 23 04 39

@manics manics deleted the jupyter-server-listen-all-ifaces branch January 27, 2025 23:08
benz0li added a commit to b-data/jupyterlab-julia-docker-stack that referenced this pull request Jan 28, 2025
benz0li added a commit to b-data/jupyterlab-mojo-docker-stack that referenced this pull request Jan 28, 2025
benz0li added a commit to b-data/jupyterlab-python-docker-stack that referenced this pull request Jan 28, 2025
benz0li added a commit to b-data/jupyterlab-r-docker-stack that referenced this pull request Jan 28, 2025
benz0li added a commit to b-data/jupyterlab-qgis-docker-stack that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants