Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete /fonts #562

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Delete /fonts #562

merged 1 commit into from
Dec 29, 2021
+0 −288

Conversation

palewire
Copy link
Collaborator

The files is this folder are now longer being called by our trimmed down bootstrap CSS. They do they need to exist and should be deleted.

@palewire palewire added this to the Streamline the site milestone Dec 27, 2021
@palewire palewire requested a review from choldgraf December 29, 2021 15:38
choldgraf
choldgraf approved these changes Dec 29, 2021
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that is the history behind these fonts, what were they being used for before? Or were they a "just for if we need it" kind is thing?

Seems reasonable to remove to me

@palewire
Copy link
Collaborator Author

They are the icon font packaged with bootstrap. We never used them. The CSS that applies them has already been cut.

@palewire palewire merged commit 10cdc92 into master Dec 29, 2021
@krassowski krassowski deleted the delete-fonts branch May 26, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Streamline the site
Development

Successfully merging this pull request may close these issues.
2 participants
@palewire @choldgraf