Skip to content

Commit

Permalink
Merge pull request #694 from martinRenou/prevent_failure_remove_kernel
Browse files Browse the repository at this point in the history
Prevent failure if kernel is not found when shutting it down
  • Loading branch information
Steven Silvester authored Sep 17, 2021
2 parents 9fdc1d2 + 0c4338d commit 1fcf65a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions jupyter_client/multikernelmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,9 @@ def remove_kernel(self, kernel_id: str) -> KernelManager:
Mainly so that a kernel can be removed if it is already dead,
without having to call shutdown_kernel.
The kernel object is returned.
The kernel object is returned, or `None` if not found.
"""
return self._kernels.pop(kernel_id)
return self._kernels.pop(kernel_id, None)

async def _shutdown_starting_kernel(self, kid: str, now: bool) -> None:
if kid in self._starting_kernels:
Expand Down

0 comments on commit 1fcf65a

Please sign in to comment.