Skip to content

Commit

Permalink
Merge pull request #379 from mpacer/config_kernel_manager
Browse files Browse the repository at this point in the history
make KernelManager configurable for all who inherit JupyterConsoleApp
  • Loading branch information
Carreau authored May 17, 2018
2 parents b754994 + f1d8a95 commit 2fae25b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
8 changes: 6 additions & 2 deletions jupyter_client/consoleapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from traitlets.config.application import boolean_flag
from ipython_genutils.path import filefind
from traitlets import (
Dict, List, Unicode, CUnicode, CBool, Any
Dict, List, Unicode, CUnicode, CBool, Any, Type
)

from jupyter_core.application import base_flags, base_aliases
Expand Down Expand Up @@ -110,7 +110,11 @@ class JupyterConsoleApp(ConnectionFileMixin):
classes = classes
flags = Dict(flags)
aliases = Dict(aliases)
kernel_manager_class = KernelManager
kernel_manager_class = Type(
default_value=KernelManager,
config=True,
help='The kernel manager class to use.'
)
kernel_client_class = BlockingKernelClient

kernel_argv = List(Unicode())
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def run(self):
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*',
extras_require = {
'test': ['ipykernel', 'ipython', 'mock'],
'test:python_version == "3.3"': ['pytest<3.3.0'],
'test:python_version == "3.3"': ['pytest>=3,<3.3.0'],
'test:(python_version >= "3.4" or python_version == "2.7")': ['pytest'],
},
cmdclass = {
Expand Down

0 comments on commit 2fae25b

Please sign in to comment.