Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some naming left behinds from migration #18

Merged
merged 1 commit into from
May 14, 2015
Merged

Clean up some naming left behinds from migration #18

merged 1 commit into from
May 14, 2015

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented May 14, 2015

Noticed this when running jupyter kernelspec.

$ jupyter kernelspec
No subcommand specified. Must specify one of: ['install-self', 'install', 'list']

Manage IPython kernel specifications.

Subcommands
-----------

Subcommands are launched as `ipython kernelspec cmd [args]`. For information on
using subcommand 'cmd', do: `ipython kernelspec cmd -h`.

install-self
    [DEPRECATED] Install the IPython kernel spec directory for this Python.
install
    Install a kernel specification directory.
list
    List installed kernel specifications.

Now it reads:

$ jupyter kernelspec
No subcommand specified. Must specify one of: ['list', 'install', 'install-self']

Manage Jupyter kernel specifications.

Subcommands
-----------

Subcommands are launched as `jupyter kernelspec cmd [args]`. For information on
using subcommand 'cmd', do: `jupyter kernelspec cmd -h`.

list
    List installed kernel specifications.
install
    Install a kernel specification directory.
install-self
    [DEPRECATED] Install the IPython kernel spec directory for this Python.

@minrk minrk added this to the 4.0 milestone May 14, 2015
minrk added a commit that referenced this pull request May 14, 2015
@minrk
Merge pull request #18 from jupyter/ipy->jupyter
9112419 
Clean up some naming left behinds from migration
@minrk minrk merged commit 9112419 into master May 14, 2015
@minrk minrk deleted the ipy->jupyter branch May 14, 2015 05:00
Carreau added a commit to Carreau/jupyter_client that referenced this pull request Feb 22, 2021
@Carreau
[DRAFT] interrupt and sigterm before sigkill kernel.
bfb2d3d 
This implements the discussion in jupyter#18, to try to more progressively stop
the kernels.

1) this always sends and interrupt before any shutdown requests;
  goal being to stop any processing happening that may block any event
  loop.

2) sends the shutdown_requests (no changes here).

3) wait 50% of the wait time, and sends a "terminate" in quote as this
depends on your platform/os, and the type of kernel you have.
    - if subprocess.Popen calls `.terminate()` which is SIGTERM on unix; the same as
    `.kill()` on windows; if not a Popen instance send SIGTERM.

4) wait the other 50% and kills, (same as before).

This does this both on the sync client and async client.

TBD: write tests and docs; and test more properly;
@Carreau Carreau mentioned this pull request Feb 22, 2021
Merged
Carreau added a commit to Carreau/jupyter_client that referenced this pull request Feb 22, 2021
@Carreau
[DRAFT] interrupt and sigterm before sigkill kernel.
93dd3ac 
This implements the discussion in jupyter#18, to try to more progressively stop
the kernels.

1) this always sends and interrupt before any shutdown requests;
  goal being to stop any processing happening that may block any event
  loop.

2) sends the shutdown_requests (no changes here).

3) wait 50% of the wait time, and sends a "terminate" in quote as this
depends on your platform/os, and the type of kernel you have.
    - if subprocess.Popen calls `.terminate()` which is SIGTERM on unix; the same as
    `.kill()` on windows; if not a Popen instance send SIGTERM.

4) wait the other 50% and kills, (same as before).

This does this both on the sync client and async client.

TBD: write tests and docs; and test more properly;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rgbkrk @minrk