extend special handling of sys.executable to pythonX[.Y] #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should allow ipykernel's wheel-installed specs to specify `python3` or `python2` and prevent python2 kernels from launching with sys.executable if the Python version is 3.
blink1073
approved these changes
Nov 22, 2017
|
Yup, I think this makes sense. Do you want anyone specific to consider this before we merge? I'm happy to press the button. |
|
I think this is pretty straightforward, so I'm happy as-is. The release process is the trickier part - what version of jupyter-client this goes in (since you are working on big 6.0 things right now), when to adopt it in ipykernel, etc. |
|
I think the big changes are still likely to take a while to settle, so it's worth doing a 5.2 release with this and other improvements. I might make a 5.x branch and back out the new discovery machinery, since that's part of the big changes I'm still working on. |
|
@meeseeksdev backport |
takluyver
added a commit
that referenced
this pull request
Dec 15, 2017
Backport PR #306 on branch 5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should allow ipykernel's wheel-installed specs to specify
python3orpython2and prevent python2 kernels from launching with sys.executable if the Python version is 3.The new KernelFinder machinery may make this obsolete, but I think we still need this for ipykernel's wheels to avoid launching with sys.executable.