Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docs with Python 3.7 on conda #435

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Build docs with Python 3.7 on conda #435

merged 1 commit into from
Apr 25, 2019

Conversation

takluyver
Copy link
Member

This might fix some failures to build on RTD, where Sphinx is failing to import something from the typing module.

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyter-client/conda/latest/bin/sphinx-build", line 6, in <module>
    from sphinx.cmd.build import main
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyter-client/conda/latest/lib/python3.5/site-packages/sphinx/cmd/build.py", line 22, in <module>
    from sphinx.application import Sphinx
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyter-client/conda/latest/lib/python3.5/site-packages/sphinx/application.py", line 34, in <module>
    from sphinx.project import Project
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyter-client/conda/latest/lib/python3.5/site-packages/sphinx/project.py", line 12, in <module>
    from typing import TYPE_CHECKING
ImportError: cannot import name 'TYPE_CHECKING'

This might fix some failures to build on RTD, where Sphinx is failing to import something from the typing module.
@takluyver
Copy link
Member Author

Merging to see if it works; this doesn't affect anything besides building docs.

@takluyver takluyver merged commit 043c0e6 into master Apr 25, 2019
@takluyver takluyver deleted the docs-env-py37 branch April 25, 2019 10:11
@takluyver
Copy link
Member Author

This did fix the docs builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant