call _create_connected_socket to instantiate _control_socket in Kerne… #456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lManager
This PR fixes a bug introduced with #447; now that
IOLoopKernelManager
exposes a decorator ofconnect_control
, this method is wrongly called by the KernelManager when creating its internal control socket: https://github.com/jupyter/jupyter_client/blob/master/jupyter_client/manager.py#L199.This results in creating a
ZMQStream
instead of a regularZMQSocket
as it was the case before, whenconnect_control
ofConnectionFileMixin
was directly called. I'm not familiar with pyzmq but this prevents theshutdown_request
message to reach the kernel, leading to always send a signal to kill it.cc @SylvainCorlay @rgbkrk