Add modal cursor option for when using vi mode #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option of having a modal cursor when using the
vi
mode.It does this by setting the
cursor
option of thePromptSession
equal to an instance ofModalCursorShapeConfig
from here.Furthermore, it adds two news options to the config file:
vi
mode)ttimeoutlen
parameter of the main Application fromprompt_toolkit
The
ttimeoutlen
is a timeout setting that affects the handling of keys; in this case, when to flush the input. I.e. it determines how long does it it take when the escape key has been pressed forprompt_toolkit
to register this and change the prompt layout according to thevi
mode. See the prompt_toolkit docs.Together with #289 this yields a descent vi mode layout for the
jupyter_console
.