Skip to content

Commit

Permalink
Fix playwright bot (#6880)
Browse files Browse the repository at this point in the history
* Add `stdout` to the playwright config

* tmp: test UI change

* add env var

* try on push

* try triggers

* more debug

* uncomment condition

* fix pr checkout

* try additional jlpm

* try copy yarnrc

* try jlpm install

* run base setup after

* try jlpm install

* try start_server_script

* try installing yarn 3

* try alias

* try with custom action

* undo previous debug

* undo test changes

* Use `npm_client`

* Update to upstream action
  • Loading branch information
jtpio authored May 25, 2023
1 parent 185778b commit 78ad211
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
12 changes: 8 additions & 4 deletions .github/workflows/playwright-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,18 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Checkout the branch from the PR that triggered the job
run: |
# PR branch remote must be checked out using https URL
git config --global hub.protocol https
hub pr checkout ${{ github.event.issue.number }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Build
uses: ./.github/actions/build-dist

Expand All @@ -55,9 +56,12 @@ jobs:
jlpm playwright install
- name: Update snapshots
uses: jupyterlab/maintainer-tools/.github/actions/update-snapshots@v1
uses: jupyter-server/maintainer-tools/.github/actions/update-snapshots@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
npm_client: jlpm
test_folder: ui-tests
start_server_script: 'null'
update_script: test:update --browser ${{ matrix.browser }}
env:
DEBUG: pw:webserver
1 change: 1 addition & 0 deletions ui-tests/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ module.exports = {
port: 8888,
timeout: 120 * 1000,
reuseExistingServer: true,
stdout: 'pipe',
},
],
};

0 comments on commit 78ad211

Please sign in to comment.