Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header markdown highlighting doesn't stop if next line begins with MathJax #10

Closed
nicktimko opened this issue Apr 13, 2015 · 4 comments · Fixed by #627
Closed

Header markdown highlighting doesn't stop if next line begins with MathJax #10

nicktimko opened this issue Apr 13, 2015 · 4 comments · Fixed by #627
Labels
status:resolved-locked
Milestone
4.1

Comments

@nicktimko
Copy link

Picture worth a thousand words:

screen shot 2015-04-13 at 11 29 10 am

But basically, a line that begins with MathJax causes the header highlighting to bleed.

Produced in OS X 10.10.1 Chrome 41.0.2272.118 and Safari 8.0.2 (10600.2.5)
@minrk
Copy link
Member

minrk commented Sep 10, 2015

While this is an issue in our ipythongfm codemirror mode, I suspect it's a bug in CodeMirror's implementation of multiplexing modes, where the multiplexing ends up stripping the previous mode's handling of newlines. Let's report it upstream.

@Carreau Carreau added this to the 4.1 milestone Sep 14, 2015
@Carreau
Copy link
Member

Carreau commented Sep 17, 2015

reported on codemirror/codemirror5#3535 to get more info, bumping as 5.0.

@Carreau Carreau modified the milestones: 5.0, 4.1 Sep 17, 2015
@Carreau
Copy link
Member

Carreau commented Sep 21, 2015

Fixed upstream. Thanks !

@Carreau Carreau closed this as completed Sep 21, 2015
@Carreau Carreau mentioned this issue Sep 21, 2015
Closed
@minrk minrk modified the milestones: 4.1, 5.0 Sep 22, 2015
@minrk minrk reopened this Sep 22, 2015
@minrk
Copy link
Member

minrk commented Sep 22, 2015

Let's leave this open and mark it closed when we ship a CodeMirror with the fix. Thanks for taking it upstream, @Carreau!

@ellisonbg ellisonbg modified the milestones: 4.1, 5.0 Oct 6, 2015
@ellisonbg ellisonbg added the bug label Oct 6, 2015
@minrk minrk removed the bug label Oct 6, 2015
@minrk minrk mentioned this issue Oct 21, 2015
Merged
willingc pushed a commit to willingc/notebook that referenced this issue Mar 10, 2016
@jdfreder
Merge pull request jupyter#10 from bollwyvl/nbext-pain-validation
16b5248 
Post-flight validation for *extension enable/list
willingc pushed a commit that referenced this issue May 6, 2016
@Carreau
Merge pull request #10 from willingc/Carreau-kerneljs
6b6adc7 
Edits to kernel specific extensions
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

CodeMirror 5.8 minrk/notebook
4 participants
@ellisonbg @minrk @Carreau @nicktimko