Untrusted notebook user experience

[Phyks]

Hi,

I got some issues with %matplotlib notebook which was discarding my figures when reloading the notebook, and replacing them with <IPython.core.display.Javascript object>. I could not figure out why, and I discovered it was due to the fact that my notebook was not trusted.

Maybe it could be a good idea to add a big warning bar on top of the notebook if running in untrusted mode, stating something like "this notebook runs in untrusted mode, some features will be disabled.", and it could improve user experience a lot.

Thanks

[Phyks]

I am having a quick look at it and think I can make a PR to handle it, if it can be useful.

I am wondering what is the best implementation:

• Either to check for the trusted status of the notebook, and display a banner on top of the page, as described initially in this issue.
• Or handle it at the OutputArea level (

  notebook/notebook/static/notebook/js/outputarea.js

  Line 558 in 932f85c

  if (!this.trusted && !OutputArea.safe_outputs[type]) {

  ) and append a banner in sanitized output areas.

What do you think?

[minrk]

If you would like to mock up an example of a better UI for untrusted output, that would be great! My first inclination would be the single global indicator, not per-output.

cc @ellisonbg @cameronoelsen

[juhasch]

I added a trusted/not trusted indicator (checkmark or cross) for notebooks in the python-markdown extension:

Not saying it should be done like this, but it might give an idea how it could looke like.

[Phyks]

👍 This looks like the perfect thing to do for me. @juhasch Maybe you want to handle a PR yourself? or want me to extract it from your extension?

[juhasch]

You are welcome to strip out the indicator an make a PR for the notebook.

[Phyks]

UI is far from perfect, but I started a PR at #1293.

I think we can discuss there of UI improvements. Thanks!

[gnestor]

Merged #1658 (comment)

Thanks @Phyks for your contribution.