Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook doesn't respond if I try to use 'Raw nbconvert' cell type + cell toolbar #3255

Closed
yuvipanda opened this issue Jan 24, 2018 · 1 comment
Closed

Notebook doesn't respond if I try to use 'Raw nbconvert' cell type + cell toolbar #3255

yuvipanda opened this issue Jan 24, 2018 · 1 comment
Labels
status:resolved-locked

Comments

@yuvipanda
Copy link
Contributor

Notebook version: 5.3.1

How to reproduce:

  1. Set an empty cell's type to 'Raw NBConvert' from the menu
  2. Show raw cell format with 'View -> Cell Toolbar -> Raw Cell Format'
  3. Select 'custom' in the cell toolbar

This makes a black overlay across the entire notebook, like a modal is going to open. But a modal never opens, and the notebook UI is inaccessible. I need to refresh page to fix this.
onnodb pushed a commit to onnodb/notebook that referenced this issue Apr 17, 2020
Fix broken "Raw cell MIME type" dialog (jupyter#3255)
2346467 
The modal dialog for entering a custom MIME type for a "Raw NBConvert"-
type cell was broken. This change to the JavaScript code makes the modal
dialog appear correctly again, as well as correctly disabling the
handling of key presses by the cell editor while the dialog is open.

This fixes jupyter#3255.
@onnodb
Copy link
Contributor

onnodb commented Apr 17, 2020

I also observed this issue today, both in version 6.0.3 and in the current master. As far as I can see, the issue is with the underlying JavaScript code. I've submitted a PR that addresses the issue, see #5385.

@onnodb onnodb mentioned this issue Apr 20, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuvipanda @onnodb