Global [role=tooltip] styles impact notebook extensions #5670
Labels
Comments
|
@magdapoppins, good catch! Would you be interested in opening a PR with your proposed fix? Otherwise, I'm happy to submit the change myself. Thanks! |
|
@Zsailer I can open a pr tomorrow. 👍 |
magdapoppins
added a commit
to magdapoppins/notebook
that referenced
this issue
Aug 12, 2020
- Change the scope of styles specific to `.dynamic-buttons` to that class only (introed in jupyter#4729) - Drop the width style from tooltips since `display: inline` makes it have no effect Fixes jupyter#5670
magdapoppins
added a commit
to magdapoppins/notebook
that referenced
this issue
Aug 12, 2020
- Change the scope of styles specific to `.dynamic-buttons` to that class only (introed in jupyter#4729) - Drop the width style from tooltips since `display: inline` makes it have no effect Fixes jupyter#5670
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In fb08a1b#diff-321a1fb8c95f4257fbede791b7856b7cR438-R459 some global styles regarding elements with
role="tooltip"were introduced. They were meant to fix issues specific to the.dynamic-buttons-div element, and wouldn't need to be put in global scope.Setting every element with
role="tooltip"visibilitytohiddenimpacts notebook extensions and makes it tedious to use this attribute correctly.I suggest changing the scope of the above mentioned style to
.dynamic-buttons [role=tooltip]in notebook/static/tree/less/tree.less line 438.The text was updated successfully, but these errors were encountered: