Remove double border in Find and replace UI. #2132
Conversation
|
Hum, it may be better to remove the |
|
Yeah, that seems right. |
Carreau
force-pushed
the
fix-find-replace-css
branch
from
d6e130a to
0151c17
Compare
Done. Also trying to use the same trick with RTL layout. Not perfect, we should inject dir='ltr' by default on the |
There is a less-than optimal double border between the last button and the input field. Remove it by making the left border of the input field None, (or the right one in RLT layout). We don't change the border of the buton or it looks ugly when pressed.
Carreau
force-pushed
the
fix-find-replace-css
branch
from
0151c17 to
6d0b45b
Compare
|
Done. Body now have I'm going to assume this may be on interest for @ebraminio and @samarsultan i'm going in unknow territory though so Appreciate input. |
|
Honeslty I don't know how to see RTL UI for this yet, a quick step-by-step guide would be nice I guess. |
I've said it in the other issue but I'll repeat here for completeness and future reader. The RTL layout is relatively bad as it was added recently. |
|
Aha, I didn't know about command palette at all :) Now I see, this patch is OK but IMHO the functionality offered by "Toggle RTL Layout" is not very correct. Is there any plan to translate whole notebook UI to an RTL language? Does notebook is going to have alternative languages for UI, like Arabic and Hebrew? If so this makes sense of course for testing proposes, otherwise, not very much. What I really like to have here, (and a friend requested me to do on this project) is the ability to just toggle result cells' direction. Of course merge of this won't collide with that. So in nutshell. This is OK to merge. Thanks. |
Ok, so we're not publicising it well enough!
There have been some requests to translate in general, and proposal for RTL (see #1852). If the usage of notebook keep increasing then we'll have to do it at some point. The open source project does not have enough resources, or knowledge to it properly though so it's not moving forward fast. We're probably not even in contact with people using RTL language to properly understand what we should be doing. So any help welcome.
Would that be on a per-cell basis ? Or on all notebook ? with a better understanding we might be able to pull that off. |
Great. Even the fact I am using a well mirrored software (MediaWiki) on every day basis, as a programmer, I personally don't see much value on making jupyter completely translated to have a RTL UI. However, I understand and appreciate the efforts there. I like to add that I see only one real and effective way making a currently LTR UI to RTL, and that is use of a CSS mirror tool, like R2 or CSSJanus, described here (reading this will be very insightful, specially the excepting rule part). Also here is a complete list of RTL languages are listed that you probably like to complete isMirroringEnabled function there, "ar|arc|arz|azb|bcc|ckb|bqi|dv|fa|glk|he|kk-arab|kk-cn|ks|ku-arab|mzn|pnb|ps|sd|ug|ur|ydd|yi".
Just per result cells. That would be really super useful. For example you are doing a RTL web scraping thing and you just want to see a part of the page\ in RTL. One other good to have RTL support feature is applying dir="auto" to all languages markdown paragraph, like what I did on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6296 |
There is a less-than optimal double border between the last button and
the input field.
Remove it by making the right border of the last button be None
Before/after:
