Remove deprecated ANSI CSS styles #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! If someone has the time, it would be good to check whether kernels are using any of the deprecated styles, so we can warn them of the change before dropping them. |
|
cc @flying-sheep @stevengj @vaibhavsagar @dsblank @jaroslawmalekcodete any concerns about removing these classes in 6.0? |
|
For further context, this is the last item marked for the 6.0 release. |
|
No concerns from me. |
|
Thanks @vaibhavsagar! I love your bio tagline, I've described myself as a software janitor as well 😄 |
|
Looks like no concerns have been expressed by some of the possible consumers, so I will be merging this for the 6.0 release shortly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the deprecation/removal policy is here ...
The new CSS styles have been released with
notebook5.0.0 in March 2017 an the deprecated styles are in the CSS CDN for up to version 5.4.0.Feel free to merge this whenever appropriate!