Fixed French translations in nbjs.po #4061
Conversation
| @@ -82,11 +83,11 @@ msgstr "Appliquer" | |||
|
|
|||
| #: notebook/static/base/js/dialog.js:225 | |||
| msgid "WARNING: Could not save invalid JSON." | |||
| msgstr "ATTENTION: Imposible de sauvegarder du JSON invalide" | |||
| msgstr "ATTENTION: Imposible de sauvegarder du JSON invalide." | |||
| @@ -1527,7 +1528,7 @@ msgid "" | |||
| "indicated by a grey cell border with a blue left margin." | |||
| msgstr "" | |||
| "<b>Mode Commande</b> déclenche au clavier des actions au niveau du notebook " | |||
| "et se reconnaît à la bordure grise de la cellule, avec une marge bleue sur " | |||
| "et se reconnaît à la bordure grise de la cellule, avec une margebleue sur " | |||
There was a problem hiding this comment.
margebleue ? Espace enlevé par erreur ?
|
+1, let me know if you want to iterate on this, or merge and do subsequent PRs. |
|
@Carreau both of your comments are now fixed, you can merge my changes. |
There was a problem hiding this comment.
@kara71 Awesome :-). Thanks a lot, I feel a bit ashamed given the number of obvious fix you made, but that is great. I left a few minor comments.
| @@ -381,7 +382,7 @@ msgstr "transformer en cellule de code" | |||
| #: notebook/static/notebook/js/actions.js:373 | |||
| #: notebook/static/notebook/js/actions.js:374 | |||
| msgid "change cell to markdown" | |||
| msgstr "transformer en cellule markdown" | |||
| msgstr "transformer celllule en markdown" | |||
There was a problem hiding this comment.
unsure for this one, what seems wrong in original translation ?
There was a problem hiding this comment.
I tried to stick better to the English version :
"change cell to markdown" = "transformer (la) cellule en markdown"
"change to markdown cell" = "transformer en cellule markdown".
I don't mind reverting to the original if you feel it's clearer
There was a problem hiding this comment.
That is my feeling, because « transformer cellule en markdown » suggests a transformation in cell content (like a conversion), which is wrong, to my understanding.
Plus the form you suggest is a bit grammatically clumsy (missing article), but maybe that is for clumsy-consistency with other messages of mine, I don't remember :-p.
No strong opinion on this though.
| @@ -514,7 +515,7 @@ msgid "" | |||
| "selected" | |||
| msgstr "" | |||
| "fusionner les cellules sélectionnées, ou la cellule courante avec la " | |||
| "suivante, si une unique cellule est sélectionnée" | |||
| "suivante si une unique cellule est sélectionnée" | |||
|
|
||
| #: notebook/static/notebook/js/actions.js:569 | ||
| msgid "show all line numbers" | ||
| msgstr "transformer en titre de niveau " |
There was a problem hiding this comment.
WTF did I do here… I feel ashamed :x
There was a problem hiding this comment.
Your translation was overall of great quality!
|
|
||
| #: notebook/static/notebook/js/actions.js:579 | ||
| msgid "hide all line numbers" | ||
| msgstr "masquer tous les numéros de ligne" | ||
|
|
||
| #: notebook/static/notebook/js/actions.js:580 | ||
| msgid "hide line numbers in all cells, and persist the setting" | ||
| msgstr "masquer tous les numéros de ligne et s'en souvenir dans les paramètres" | ||
| msgstr "masquer les numéros de ligne dans toutes les cellules, et s'en souvenir dans les paramètres" |
|
|
||
| #: notebook/static/notebook/js/actions.js:813 | ||
| msgid "toggle all cells output collapsed" | ||
| msgstr "inverser l'état d'affichage de toutes les sorties (affiché/masqué)" | ||
| msgstr "afficher/masquer toutes les sorties en mode compact" |
| @@ -868,11 +869,11 @@ msgstr "" | |||
|
|
|||
| #: notebook/static/notebook/js/notebook.js:470 | |||
| msgid "Restart and Run All Cells" | |||
| msgstr "Relancer et Exécuter Toutes les Cellules" | |||
| msgstr "Relancer et exécuter toutes les cellules" | |||
There was a problem hiding this comment.
If we start not transposing English uppercases to uppercases in French version also, there is a broader work to be done in French translation.
I chosen first to keep capitalization like in English version, but it seems that this is common to have english version of a software with Kind a Camel Case Menu Entry and French with Pas de camel case… So I do agree to remove English-style capitalization, but suggest to do it fully here, either here or in another PR ?
There was a problem hiding this comment.
I tried to coordinate my efforts with @agatheliguori who removed Title Case entirely in another file on #4074. I'll probably do another pass on this file as well.
There was a problem hiding this comment.
OK, just to avoid dying idiot or doubting : the rationale behind those changes is that ortho-typography differs between French and English on how to capitalize titles, right ?
|
|
||
| #: notebook/static/notebook/js/notebook.js:471 | ||
| msgid "Restart and Clear All Outputs" | ||
| msgstr "Relancer et Effacer Toutes les Sorties" | ||
| msgstr "Relancer et effacer toutes les sorties" | ||
|
|
Don't be, we all read through that, and working in two languages is super hard. |
Fixed some translation mistakes and typos.
@JocelynDelalande You're the main contributor for this so please have a look !
@Carreau might be interested too.
I might do the other .po files later