Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links for contributor #5600

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Fix broken links for contributor #5600

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff509cc
Fix broken links
Nishikoh Jul 10, 2020
a8522bb
Fix link to `Project Jupyter Documentation Guide`
Nishikoh Jul 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ General Guidelines
For general documentation about contributing to Jupyter projects, see the
`Project Jupyter Contributor Documentation`__.

__ https://jupyter.readthedocs.io/en/latest/contributor/content-contributor.html
__ https://jupyter.readthedocs.io/en/latest/contributing/content-contributor.html


Setting Up a Development Environment
Expand Down Expand Up @@ -201,4 +201,4 @@ Windows users can find ``make.bat`` in the ``docs`` folder.

You should also have a look at the `Project Jupyter Documentation Guide`__.

__ https://jupyter.readthedocs.io/en/latest/contrib_docs/index.html
__ https://jupyter.readthedocs.io/en/latest/contributing/content-contributor.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nishikoh - thank you for this contribution!

I think the intention of this link is to point to the documentation guide, which appears to be here: https://jupyter.readthedocs.io/en/latest/contributing/docs-contributions/index.html

Once updated, I'd be happy to merge. Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! Fixed it :D