Fix bug where multiselection was canceled on menu click. #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdfreder
force-pushed
the
multiselectmenu
branch
from
b28245b to
75f2db7
Compare
| @@ -660,26 +660,43 @@ define(function (require) { | |||
| /** | |||
| * Programmatically select a cell. | |||
| * | |||
| * @param {integer} index - A cell's index | |||
| * @param {integer||integer[]} [indicies] - A cell's index or list of indicies | |||
There was a problem hiding this comment.
"indices" - also misspelled various places below in code or comments.
cause by inconsistency in API
jdfreder
force-pushed
the
multiselectmenu
branch
from
75f2db7 to
7d9fbc9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #558
closes #566