Fix issue #3218 #6108
Merged
Fix issue #3218 #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
approved these changes
Jul 21, 2021
|
@kevin-bates thanks for approving the changes 😃 and for all your support. Looking forward to my PR getting merged. |
|
Hi @Nazeeh21 - in speaking with some colleagues about his PR - which looks good, they suggested that comments indicating that the particular lines were updated for the purpose of accessibility be added, perhaps something like (Sorry for the delay in getting back, I just realized that I had never submitted a comment similar to this one a couple of days ago.) |
|
Sure, I will add |
kevin-bates
approved these changes
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, on route
localhost/tree/docsthe word "running" appearing next to the file name of the new notebook was failing the color contrast.Before fixing
After fixing
**On route
localhost/tree#running(a new notebook is running) kernel-name wasn't too dark.Before fixing
After fixing
For new notebook, on route
http://localhost/notebooks/docs/Untitled.ipynbthe contrast for kernel_indicator was failing.Before fixing
After fixing
Fixes #3218