Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs parity for find with JupyterLab. #6917

Merged
merged 5 commits into from
Jun 21, 2023

Conversation

ericsnekbytes
Copy link
Collaborator

@ericsnekbytes ericsnekbytes commented Jun 12, 2023

This PR updates the find documentation to match changes in JupyterLab's. Questions that need to be answered:

  • Can users disable windowed rendering in Notebook the same way they can in Lab, as suggested by @krassowski for Lab?

Original PRs for reference:

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch ericsnekbytes/notebook/find_docs_parity_jlab

docs/source/notebook.md Outdated Show resolved Hide resolved
@ericsnekbytes ericsnekbytes marked this pull request as ready for review June 21, 2023 16:27
@ericsnekbytes
Copy link
Collaborator Author

@jtpio Can you approve this one (the related Lab PR has been merged now) then one of us can merge it?

@jtpio
Copy link
Member

jtpio commented Jun 21, 2023

Cool, thanks for working on this 👍

@jtpio jtpio added this to the 7.0 milestone Jun 21, 2023
@jtpio jtpio merged commit 7c84112 into jupyter:main Jun 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants