Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow zmq check_origin with no args #914

Merged
merged 1 commit into from
Dec 31, 2015
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Dec 31, 2015

terminado may call self.check_origin()

in which case we should grab origin from the headers.

closes #912

terminado may call `self.check_origin()`

in which case we should grab origin from the headers.
@minrk minrk added this to the 4.1 milestone Dec 31, 2015
@ellisonbg
Copy link
Contributor

Thanks, I will test this shortly.

On Thu, Dec 31, 2015 at 1:43 AM, Min RK [email protected] wrote:

terminado may call self.check_origin()

in which case we should grab origin from the headers.

closes #912 #912

You can view, comment on, or merge this pull request online at:

#914
Commit Summary

  • allow zmq check_origin with no args

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#914.

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]

@ellisonbg
Copy link
Contributor

I have confirmed that this fixes the issue, merging.

ellisonbg added a commit that referenced this pull request Dec 31, 2015
allow zmq check_origin with no args
@ellisonbg ellisonbg merged commit d86714a into jupyter:master Dec 31, 2015
@minrk minrk deleted the check-origin branch December 31, 2015 20:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal broken on master of notebook and terminado
2 participants