Avoid the need for read:hub scope #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using /hub/api that returns a json-blob with a single version field that we need, we don't require the `read:hub` scope for access to the /hub/api/info endpoint that provides the hub version and more.
consideRatio
commented
Oct 14, 2021
Comment on lines
-166
to
+167
| info = json.loads(resp.body.decode("utf8", "replace")) | ||
| state_filter = V(info["version"]) >= STATE_FILTER_MIN_VERSION | ||
| resp_model = json.loads(resp.body.decode("utf8", "replace")) | ||
| state_filter = V(resp_model["version"]) >= STATE_FILTER_MIN_VERSION |
There was a problem hiding this comment.
I saw resp_model was used elsewhere as a naming convention, so I liked the idea of changing this variable name from being named info after switching the endpoint from /info to /.
consideRatio
commented
Oct 14, 2021
| resp = await fetch(HTTPRequest(url=url + "/info", headers=auth_header)) | ||
| resp = await fetch(HTTPRequest(url=url + "/", headers=auth_header)) |
There was a problem hiding this comment.
I've verified that the / endpoint of the api returns a json object with a version key at least in jupyterhub 1.4.2, but I've not tested this code manually.
I opened #36 regarding this repo's lack of tests.
There was a problem hiding this comment.
I know I could in theory remove the auth header for this request, but I figure it makes sense that all requests no matter what passes the provided token for logging purposes in the hub pod etc anyhow.
minrk
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using /hub/api that returns a json-blob with a single version field
that we need, we don't require the
read:hubscope for access to the/hub/api/info endpoint that provides the hub version and more.