More IPv6: Use bare IPv6 for configuration, use [ipv6] when displaying IPv6 outputs
#4988
Conversation
JUPYTERHUB_SERVICE_URL: ipv6 must be wrapped in `[]`
| In most cases, this does not result in a change in behavior, | ||
| as '' was interpreted as 'unspecified', | ||
| which used the subprocesses' own default, itself usually '127.0.0.1'. | ||
| Default changed to '127.0.0.1', from unspecified. |
There was a problem hiding this comment.
I'm not sure whether to update or leave this text. It made sense in the context of the 2.0 upgrade, but coupled with subsequent changes it potentially adds confusion.
In hindsight how we interpret the meaning of '' affects how we treat #4986
If we consider '' == 127.0.0.1 a bug, which is what I was thinking since it's otherwise impossible to pass '' to the singleuser server, then the meaning of '' has changed from unspecified (prior to 2.0) to impossible/invalid (between 2.0 and the current release) to all interfaces (#4986).
However if we consider '' == 127.0.0.1 intentional then #4986 is a breaking change- which we could workaround by making '*' mean all interfaces instead. However this risks adding more confusion since it'll still be converted to '' when passed to the singleuser server.
No description provided.