Added new config params for using NTLM based authentication ( ie: windows ldap server) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 16, 2016 11:47
…ed valid results)
|
Thanks for the PR @oneklc. I'm going to defer to @yuvipanda for a formal review and decision to include NTLM since Yuvi has been most involved in this authenticator. A few general thoughts:
|
|
Agreed regarding NTLM defaulting to false and |
|
Hello! I'm inclined to merge #12 first, since that seems to be required in some ways for proper AD support. |
|
Hello! I'm going to discard this for right now, since a bunch of other related PRs were merged. Feel free to re-open if they are missing some feature this needs! Thanks for the patch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was easy to modify to add NTLM support.
I did not test previous settings to see if they still work.
The changes made are just working for me.
Feel free to reject the pull request.
Thanks for maintaining the ldapauthenticator.