Merge pull request #3235 from yuvipanda/mtu

Explicitly set docker's MTU to 1450
jupyterhub · Feb 21, 2025 · fc8ba66 · fc8ba66
2 parents 6379bd8 + 4ea3cdd
commit fc8ba66
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/config/hetzner-2i2c-bare.yaml b/config/hetzner-2i2c-bare.yaml
@@ -65,11 +65,6 @@ binderhub:
     GOOGLE_APPLICATION_CREDENTIALS: /secrets/service-account.json
 
   dind:
-    daemonset:
-      extraArgs:
-        # Increase limit from default of 5, as we have only one builder node
-        # But there are enough resources on the node to handle it
-        - --max-concurrent-uploads=32
     resources:
       requests:
         cpu: "4"

diff --git a/config/hetzner-2i2c.yaml b/config/hetzner-2i2c.yaml
@@ -63,11 +63,6 @@ binderhub:
     GOOGLE_APPLICATION_CREDENTIALS: /secrets/service-account.json
 
   dind:
-    daemonset:
-      extraArgs:
-        # Increase limit from default of 5, as we have only one builder node
-        # But there are enough resources on the node to handle it
-        - --max-concurrent-uploads=32
     resources:
       requests:
         cpu: "4"

diff --git a/mybinder/values.yaml b/mybinder/values.yaml
@@ -345,6 +345,14 @@ binderhub:
 
   imageBuilderType: dind
   dind:
+    daemonset:
+      extraArgs:
+        # Allow for concurrent pushes so pushes are faster
+        - --max-concurrent-uploads=32
+        # Set mtu explicitly to 1450, as sometimes docker sets it to 1500
+        # instead and that breaks *some* websites randomly *some* of the time
+        # See https://discourse.jupyter.org/t/error-in-mybinder-org-there-is-no-package-called-irkernel/32478/17
+        - --mtu=1450
     resources:
       requests:
         cpu: "0.5"