Run a cronJob every 30m to cleanup docker buildkit cache #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/buildx#1065 (comment) is the best documentation on this command, and it should fully be able to replace what our imageCleaner currently does. And it's necessary, as I think imageCleaner doesn't actually clean up buildkit cache anymore. This should be upstreamed into the helm chart, and imageCleaner deprecated / removed. However, I want to merge https://github.com/2i2c-org/binderhub-service/ into binderhub and turn that into the chart first, so we don't have to keep repeating work there. So in the meantime, this cronjob is here so we don't have mybinder.org outages (as happened in https://jupyter.zulipchat.com/#narrow/channel/469744-jupyterhub/topic/mybinder.2Eorg.20outage)
|
testing on the bare instance to see if that works |
yuvipanda
force-pushed
the
scheduledjob
branch
from
48bae61 to
4160f87
Compare
for more information, see https://pre-commit.ci
Apparently the error message is wrong and --max-storage is not actually implemented lol
|
We still need the imageCleaner, until jupyterhub/repo2docker#1414 lands. Then it can be disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker/buildx#1065 (comment) is the best documentation on this command, and it should fully be able to replace what our imageCleaner currently does. And it's necessary, as I think imageCleaner doesn't actually clean up buildkit cache anymore.
This should be upstreamed into the helm chart, and imageCleaner deprecated / removed. However, I want to merge https://github.com/2i2c-org/binderhub-service/ into binderhub and turn that into the chart first, so we don't have to keep repeating work there. So in the meantime, this cronjob is here so we don't have mybinder.org outages (as happened in https://jupyter.zulipchat.com/#narrow/channel/469744-jupyterhub/topic/mybinder.2Eorg.20outage)