Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set docker's MTU to 1450 #3235

Merged
merged 1 commit into from
Feb 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions config/hetzner-2i2c-bare.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@ binderhub:
GOOGLE_APPLICATION_CREDENTIALS: /secrets/service-account.json

dind:
daemonset:
extraArgs:
# Increase limit from default of 5, as we have only one builder node
# But there are enough resources on the node to handle it
- --max-concurrent-uploads=32
resources:
requests:
cpu: "4"
Expand Down
5 changes: 0 additions & 5 deletions config/hetzner-2i2c.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,6 @@ binderhub:
GOOGLE_APPLICATION_CREDENTIALS: /secrets/service-account.json

dind:
daemonset:
extraArgs:
# Increase limit from default of 5, as we have only one builder node
# But there are enough resources on the node to handle it
- --max-concurrent-uploads=32
resources:
requests:
cpu: "4"
Expand Down
8 changes: 8 additions & 0 deletions mybinder/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,14 @@ binderhub:

imageBuilderType: dind
dind:
daemonset:
extraArgs:
# Allow for concurrent pushes so pushes are faster
- --max-concurrent-uploads=32
# Set mtu explicitly to 1450, as sometimes docker sets it to 1500
# instead and that breaks *some* websites randomly *some* of the time
# See https://discourse.jupyter.org/t/error-in-mybinder-org-there-is-no-package-called-irkernel/32478/17
- --mtu=1450
resources:
requests:
cpu: "0.5"
Expand Down
Loading