binder-badge can use new pull_request_target

[manics]

binder-badge.yml will now work with pull requests from forks, using the new pull_request_target.
the action is also changed to use the commit sha instead of the branch name- since it's automatically run after every push to a PR this probably makes more sense than repeatedly posting a badge with the same branch name.

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[manics]

See an example on microscopepony/idr0083-sars-cov2-notebook#5

@hamelsmu this uses pull_request_target: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks

[hamelsmu]

Yep can confirm this works. This feature came out yesterday. Cheers

[choldgraf]

gah this is cool!

[hamelsmu]

@choldgraf can we merge this?

[choldgraf]

I don't know the infra on this one super well so am probably not best to say if (technically-speaking) it's good to merge, but I trust y'alls judgment 👍

[hamelsmu]

@choldgraf you are going to have to push the button, I don't have the permissions

[choldgraf]

🤦‍♂️ my bad!

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️