Terms of Service #148
Merged
Terms of Service #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that merging pr #145 pr #146 and pr #148 together will confuse git since there are some changes appearing on the same line. This is annoying, but there is no actual conflict, the changes are totally orthogonal and should be simply included from each one of them. See my main branch to see how I merged them together. |
This was referenced May 10, 2021
Merged
|
Is there any plan to merge this PR? No pressure, just asking to plan accordingly for some deployments (i.e. if you plan to merge "soon", we'll pull the main repo which we'd love to, otherwise we'll pull my fork). Let me know if there is anything in my code that you'd like to see changed to ease the merge. |
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to include a checkbox to force acceptance of Terms of Service before SignUp if desired.