Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauthenticator googlegroups extras and cleanup dependencies #3523

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Sep 30, 2024

  • We had nullauthenticator package explicitly installed, but its now an authenticator class part of jupyterhub.
  • We had pyjwt and mwoauth installed for oauthenticator, but its better we use the oauthenticator extras to install things when possible as that allows oauthenticator to put constraints on versions. So mwoauth is now installed that way, and pyjwt is installed by oauthenticator no matter what nowdays.
  • The oauthenticator[googlegroups] extras has been installed as it was a requirement for full function of google groups things.

@manics manics merged commit bcaecd4 into jupyterhub:main Sep 30, 2024
15 checks passed
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants