Remove circular references when stringifying an object #11
Conversation
|
Thanks! This seems to be working fine when testing on Binder:
Using a snippet like in: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#issue_with_json.stringify_when_serializing_circular_references |
| @@ -169,13 +169,31 @@ const extension: JupyterFrontEndPlugin<void> = { | |||
| const _trace = console.trace; | |||
| const _table = console.table; | |||
|
|
|||
| // https://stackoverflow.com/a/11616993 | |||
There was a problem hiding this comment.
Wondering whether we want to take this approach though.
As mentioned in the SA answer:
The replacer in this example is not 100% correct (depending on your definition of "duplicate"). In the following case, a value is discarded:
This indeed discards some of the elements:
There was a problem hiding this comment.
Added a warning message informing the user about the possibility of missing attributes
|
Binder link working https://mybinder.org/v2/gh/QuantStack/jupyterlab-js-logs/circular-references |
|
Nice! |
src/index.ts
Outdated
| const msg = | ||
| 'This error contains a object with a circular reference. During the process of removing the reference we could have removed duplicated attributes.\n'; | ||
| const obj = JSON.stringify(arg, refReplacer); | ||
| cache = []; | ||
| console.error(msg, obj); | ||
| data += obj; | ||
| } catch (e) { | ||
| data += ' '; | ||
| } |
There was a problem hiding this comment.
Maybe we could do a quick refactor if this piece of code is the same in all cases?
There was a problem hiding this comment.
ooh, thanks. I forgot about that.
I'm on it.
|
Let's wait for CI and a quick check on Binder and this should be good to go. |
|
Binder seems to be having issues right now. Just pulled locally and it looks good 👍
|
Remove circular references when stringifying an object because otherwise, the
JSON.stringifythrows an error.