Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set name as jupyterlab-js-logs #17

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Set name as jupyterlab-js-logs #17

merged 1 commit into from
Sep 15, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 15, 2021

Keep the name as jupyterlab-js-logs

@jtpio
Copy link
Member Author

jtpio commented Sep 15, 2021

We could move most of the metadata to setup.cfg, but most of it is read from the package.json so we can leave it as it is:

https://github.com/QuantStack/jupyterlab-js-logs/blob/ebfac4388a50f68d84ae73c602a88ac756c4a638/setup.py#L35-L60

@jtpio jtpio requested a review from hbcarlos September 15, 2021 08:16
@hbcarlos
Copy link
Contributor

Thanks!!

@hbcarlos hbcarlos merged commit 62cef99 into jupyterlab-contrib:main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbcarlos hbcarlos Awaiting requested review from hbcarlos

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @hbcarlos