Create theme exporter #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta to the server. Save it to a json file. Reformatting and addition of comments for the code of model.ts
…d in the theme editor interface. A new variable.css file is generated from a template.css
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
|
|
…o an hexadecimal compatible string was not working due to the presence of white spaces. Inversion between white and black hexadecimal affection was also corrected.
HaudinFlorence
force-pushed
the
create_theme_exporter
branch
from
807de26 to
f74e73b
Compare
fcollonval
requested changes
Jan 20, 2023
jupyter_theme_editor/handlers.py
Outdated
Comment on lines
23
to
25
| env = Environment(loader=PackageLoader( | ||
| "jupyter_theme_editor", "templates")) | ||
| j2_template = env.get_template("template.css") |
There was a problem hiding this comment.
We can do thing a bit better here because the Environment and finding the template is gonna be always the same. We can pass them in the initialize to avoid recreating them every time.
See that example:
And how to pass the keyword arguments to initialize
There was a problem hiding this comment.
@fcollonval Thanks a lot for the review. A tentative changed is proposed in commit c8c9a6e
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
HaudinFlorence
force-pushed
the
create_theme_exporter
branch
from
3694bb2 to
3162819
Compare
HaudinFlorence
force-pushed
the
create_theme_exporter
branch
from
3162819 to
c186873
Compare
fcollonval
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of the theme editor where the parameters changed in the theme editor are exported to a
variable.cssfile that can be downloaded.