Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes slides width #37

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Fixes slides width #37

merged 4 commits into from
Jul 24, 2023

Conversation

hbcarlos
Copy link
Contributor

Fixes #13

It also adds the logic to send log messages from the iframe to the parent window. It is useful in development.

@github-actions
Copy link

Binder 👈 Launch a Binder on branch hbcarlos/rise/fix_13

@fcollonval fcollonval added the bug Something isn't working label Jul 21, 2023
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

Two small comments; including the one to fix the CI 😉

packages/lab/src/index.ts Outdated Show resolved Hide resolved
packages/lab/src/preview.ts Show resolved Hide resolved
packages/application/src/plugins/rise.ts Show resolved Hide resolved
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

@fcollonval fcollonval merged commit efac74f into jupyterlab-contrib:main Jul 24, 2023
@hbcarlos hbcarlos deleted the fix_13 branch September 4, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slide width does not adjust when switching to full-screen mode
2 participants