This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Automagically starts the debugger if the kernel supports it #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanMabille
force-pushed
the
auto_start
branch
from
7d93e66 to
4ec426e
Compare
|
This is ready for review and merge. There is a workaround due to breakpoints being updated upon each cell change. THis can lead to send a debug request to a kernel that is not ready yet. A betteer fix would be to keep the list of all the breakpoints of a Notebook, and let the restoreSession update them when we switch to another notebook. |
jtpio
reviewed
Oct 30, 2019
src/breakpoints/index.ts
Outdated
| @@ -92,11 +92,13 @@ export namespace Breakpoints { | |||
| } | |||
|
|
|||
| set breakpoints(breakpoints: IBreakpoint[]) { | |||
| console.log('setbreakpoints called'); | |||
JohanMabille
force-pushed
the
auto_start
branch
from
4ec426e to
e573acc
Compare
jtpio
reviewed
Oct 30, 2019
|
Pretty neat. Found this while trying it out locally:
But it's probably something that falls under #76. |
|
Yes and it should be solved if we implement #130 (meaning we wouldn't have to check if the kernel is ready at all) |
jtpio
approved these changes
Oct 30, 2019
|
The other changes in the diff are related to the linting (#116 and more will come). |
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117 and #110.
This removes the start and stop commands form the palette and implements the following behavior: